New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix audit union loop variables in closures #110145
fix audit union loop variables in closures #110145
Conversation
5dac79f
to
85b027e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, sxllwx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
/kind bug |
/release-note-none |
@pacoxu Maybe we need a release note. Without this patch, if multiple AuditWebhooks are configured, only one will actually work. |
/hold |
1 similar comment
/hold |
/release-note-edit
|
thx~ |
@pacoxu, can we unhold? |
release note has been added, I think it can be unhold. |
/unhold |
@sxllwx , can you also prepare backports to all affected release branches? Thanks in advance! |
Sure, but I don't know which release branch I should port to. If you have a list here, could you please provide it to me? |
/retest |
@pacoxu @ialidzhikov This problem does exist in 1.21~1.24. I have backported this change to these branches. Please review them both. thx~ |
…45-upstream-release-1.23 Automated cherry pick of #110145: fix audit union loop variables in closures
…45-upstream-release-1.22 Automated cherry pick of #110145: fix audit union loop variables in closures
…45-upstream-release-1.24 Automated cherry pick of #110145: fix audit union loop variables in closures
What type of PR is this?
What this PR does / why we need it:
When we have at least two audit backends, only one will be activated, and that backend will be started twice.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: