New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube-proxy: windows: Removed hnsV1 #110957
Conversation
Welcome @papagalu! |
Hi @papagalu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig windows |
@jsturtevant: GitHub didn't allow me to request PR reviews from the following users: daschott. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind deprecation |
hnsV1 not supported anymore Signed-off-by: Dimitrie Mititelu <dmititelu@cloudbasesolutions.com>
Hi @papagalu, k8s 1.25 Bug Triage Shadow here, just checking in to see if this is still on track for k8s 1.25? |
@jsturtevant: GitHub didn't allow me to assign the following users: daschott. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. |
@marosset May I know which component relies on hnsv1 api, docker or WS2019? |
WS2019 as far as i know |
WS2019 exposes hnsv1 and hnsv2 APIs (same for hcsv1 an hcsv2). |
Yes, WS2019 supports both v2 and v1. Duplicating code for both v1/v2 is a big maintenance overhead so we should use only v2 going forward. v1 is used on Windows Server versions before Windows Server 2019. However since these older OS versions are not supported by Kubernetes this should be safe to remove. |
HNS apis can also be used directly by CNI binaries/plugins. |
Thank all of you for the answers. It seems like that we do not need to do anything with this change since we are using WS2019/WS2022 and docker will be deprecated in k8s 1.24+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, jsturtevant, marosset, papagalu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@papagalu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
These changes LGTM but reviewing this there are still some v1 calls left in proxier.go ( |
Signed-off-by: Dimitrie Mititelu dmititelu@cloudbasesolutions.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: