New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[golang] Update to 1.19rc2 (from 1.18.3) #111254
[golang] Update to 1.19rc2 (from 1.18.3) #111254
Conversation
@dims: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-sig api-machinery |
/remove-sig api-machinery |
@leilajal: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
huh... did 1.19 gofmt make all those comment changes? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, klueska, liggitt, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-verify |
pull-kubernetes-verify-go-canary passed looks like all the failures in pull-kubernetes-verify were formatting ones which will resolve when we bump test-infra |
@liggitt yep that landed in kubernetes/test-infra#26920 and i am retesting the 2 jobs after that. |
/remove-sig api-machinery |
/hold cancel |
This is causing an annoying gofmt change: https://github.com/kubernetes-sigs/structured-merge-diff/pull/220/files#diff-054f947623025b6f29ed3f11f2849794e09e83d9a31927598d4c1f059e7c4fe1 |
xref https://tip.golang.org/doc/go1.19#go-doc
I'd recommend committing the go1.19 version of the doc, which go1.18 gofmt will leave alone |
Yeah, nested lists aren't supported in comments by gofmt which is unfortunate and clearly changes the meaning of some comments. |
filed an issue with golang golang/go#54129 |
There's an example at the very bottom here: https://tip.golang.org/doc/comment I guess they will probably close the issue :( |
Go 1.19 GA release is planned for the first week of August:
https://groups.google.com/g/golang-dev/c/4xsD_D5oflI/m/77Ofgt_EAAAJ?utm_medium=email&utm_source=footer
With this PR, we would update to go1.19 rc2 and when the GA is available, we would move to that.
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: