New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate kubescheduler ComponentConfig v1beta2 #111547
Deprecate kubescheduler ComponentConfig v1beta2 #111547
Conversation
@kerthcet: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @alculquicondor |
@@ -67,6 +67,7 @@ func encodeConfig(cfg *config.KubeSchedulerConfiguration) (*bytes.Buffer, error) | |||
var encoder runtime.Encoder | |||
switch cfg.TypeMeta.APIVersion { | |||
case configv1beta2.SchemeGroupVersion.String(): | |||
klog.Warning("KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encodeConfig is not called if the log verbosity level is less than 2.
We should probably do this in loadConfig instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated.
1fcdcf2
to
920d6fb
Compare
PTAL @alculquicondor |
@@ -51,6 +51,9 @@ func loadConfig(data []byte) (*config.KubeSchedulerConfiguration, error) { | |||
// conversion. See KubeSchedulerConfiguration internal type definition for | |||
// more details. | |||
cfgObj.TypeMeta.APIVersion = gvk.GroupVersion().String() | |||
if cfgObj.TypeMeta.APIVersion == configv1beta2.SchemeGroupVersion.String() { | |||
klog.Warning("KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "will be removed"
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kerthcet <kerthcet@gmail.com>
920d6fb
to
c8fbd78
Compare
Updated @alculquicondor |
/lgtm |
Can you remove it now before the code freeze? |
nvm, we said 1.28 in #112257 |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind cleanup
/sig scheduling
What this PR does / why we need it:
Maintaining three ComponentConfig versions simultaneously seems unnecessary, so we'd like to remove the
v1beta2
. But in v1.25, we'll mark it deprecated at first then remove it in v1.26 for smoothly migration.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Log line looks like:
W0730 00:37:46.130858 57861 configfile.go:73] KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: