New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not raise an error proposing to use '--overwrite' when labeling with the same value #105936
Conversation
@zigarn: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @zigarn! |
Hi @zigarn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For reviewer: Looks like |
/ok-to-test |
@zigarn Can you add some unit test cases for the change? Thank You |
@lauchokyip Tests fixed (I was wrong on my local test launch) |
Thanks for the PR! This LGTM but I don't have the history behind this behavior. I'll check with some folks Wednesday and circle back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
/lgtm
/approve
/label tide/merge-method-squash
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddiezane, zigarn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/retest @eddiezane: I rebased to fix the new test |
/retest |
/lgtm |
/retest |
1 similar comment
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
…th the same value (kubernetes#105936) * Do not propose to use '--overwrite' when labeling with the same value * Check expected error value in label_test.TestLabelFunc
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, when trying to set a label with the same value as current one,
kubectl
advise to use the--overwrite
option:But then, overwriting for the same value is a bit weird.
This PR propose to detect this situation and do nothing:
Which issue(s) this PR fixes:
No existing issue.
Special notes for your reviewer:
Maybe, it could give a better output like "xxx label unchanged".
But it would require quite more modifications.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: