New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves message for pod status in rejectPod #112644
Conversation
Welcome @vitorfhc! |
Hi @vitorfhc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test @vitorfhc please include the release notes section to the PR description. |
/auto-cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note The pod admission error message was improved for usability.
/lgtm
/lgtm |
/assign @Random-Liu |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, SergeyKanzhelev, vitorfhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The change made in kubernetes#112644 resulted in an update to the rejection message. In the memory manager node e2e test, we still checked against the old expected error message giving the impression that the pod succeeded to run even though it failed as expected mainly because the check wasn't performed correctly. In this patch, we update to the correct rejection message to make sure that the memory manager is no longer failing. NOTE: This test is supposed to run on multi NUMA systems and if the underlying node does not have multi NUMA nodes, the test is skipped which is what happens in upstream test infrastructure as it is mainly composed of single NUMA nodes. Because of this, this test failure wasn't evident via testgrid. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
The change made in kubernetes#112644 resulted in an update to the rejection message. In the memory manager node e2e test, we still checked against the old expected error message giving the impression that the pod succeeded to run even though it failed as expected mainly because the check wasn't performed correctly. In this patch, we update to the correct rejection message to make sure that the memory manager is no longer failing. NOTE: This test is supposed to run on multi NUMA systems and if the underlying node does not have multi NUMA nodes, the test is skipped which is what happens in upstream test infrastructure as it is mainly composed of single NUMA nodes. Because of this, this test failure wasn't evident via testgrid. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
It improves the log messages for pods' statuses.
Which issue(s) this PR fixes:
Fixes #112605
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: