Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apimachinery/clock: Delete the apimachinery/clock package #109752

Merged
merged 1 commit into from May 17, 2022
Merged

apimachinery/clock: Delete the apimachinery/clock package #109752

merged 1 commit into from May 17, 2022

Conversation

MadhavJivrajani
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Delete the clock package after having a soak period
of 1 release cycle (1.24). The package that should
be used now is the k8s.io/utils/clock package.

Which issue(s) this PR fixes:

Fixes #94738

Special notes for your reviewer:

It was suggested that we wait for a release or two to make it easier for folks to migrate
their code: #94738 (comment)

Types were deprecated in 1.23.

Does this PR introduce a user-facing change?

apimachinery/clock: This deletes the apimachinery/clock package. Please use k8s.io/utils/clock instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @MikeSpreitzer @liggitt

@MadhavJivrajani
apimachinery/clock: Delete the clock package
43f0918 
Delete the clock package after having a soak period
of 1 release cycle (1.24). The pacakge that should
be used now is the k8s.io/utils/clock package.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2022
@MadhavJivrajani
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2022
@MadhavJivrajani
Copy link
Contributor Author

/priority backlog
/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t May 2, 2022 13:22
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2022
@MikeSpreitzer
Copy link
Member

Do we have a community policy that says how long the soak period should be?

@fedebongio
Copy link
Contributor

@MikeSpreitzer I actually don't know, but looks like we don't have one official policy for packages.

/cc @lavalamp @deads2k @liggitt
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 3, 2022
@lavalamp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit b07ee36 into kubernetes:master May 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 17, 2022
@lobziik lobziik mentioned this pull request Sep 27, 2022
Merged
@Nuru Nuru mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sttts sttts Awaiting requested review from sttts

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@lavalamp lavalamp

@liggitt liggitt

@MikeSpreitzer MikeSpreitzer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

There are two clock packages with divergent history
6 participants
@MadhavJivrajani @k8s-ci-robot @MikeSpreitzer @fedebongio @lavalamp @liggitt