New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #113286: Merge pull request #113133 from #113968
Automated cherry pick of #113286: Merge pull request #113133 from #113968
Conversation
…k-of-kubernetes#113133-upstream-release-1.25 Automated cherry pick of kubernetes#113133: Fix DeleteCollection API decode DeleteOptions fail
/release-note-edit
|
/retest-required |
/triage accepted |
#113286 (comment) said this bug was 1.25+ only... is that accurate? |
For reference: answered here: #113967 (comment) |
/lgtm this makes deletecollection consistent with what delete was already doing as well |
/approve cancel actually, I'm not sure this is correct in isolation... it may have to be combined with #113918 to be correct |
tested on release-1.24 and with this PR, and verified that no currently working DELETECOLLECTION calls regress, and one failing case starts working /lgtm |
LGTM label has been added. Git tree hash: ab40633eb745806cf7504d6b940d85a223b2803c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sxllwx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
/lgtm |
Cherry pick of #113286 on release-1.24.
#113286: Merge pull request #113133 from
For details on the cherry pick process, see the cherry pick requests page.