New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ratcheting validation for x-kubernetes-list-type #111866
Conversation
…st-type validation Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 16 07:37:26 UTC 2022. |
/cc @liggitt |
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the test case
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
d1a3322
to
c4c3ff4
Compare
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #106401
Special notes for your reviewer:
Does this PR introduce a user-facing change?