New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregated discovery server changes #113171
Aggregated discovery server changes #113171
Conversation
ae3bc6b
to
a4f435f
Compare
cf36f6d
to
a7d1f8c
Compare
8d485cb
to
b28ed83
Compare
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
5fc3f4f
to
6d639b9
Compare
squashed commits, all outstanding feedback believed to be addressed /assign @apelisse |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
for vendor/modules.txt
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, deads2k, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
3e9b359
to
91d0d48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
/milestone v1.26 This was approved and lgtm'ed well before the code freeze deadline. Hung up on a very long merge queue. |
@Jefftree: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
server support for aggregated discovery. Supports /apis handler receiving content negotiation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: