Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregated discovery server changes #113171

Merged
merged 5 commits into from Nov 9, 2022
Merged

Aggregated discovery server changes #113171

merged 5 commits into from Nov 9, 2022

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Oct 19, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

server support for aggregated discovery. Supports /apis handler receiving content negotiation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes, aggregated discovery will be alpha and can be toggled with the AggregatedDiscoveryEndpoint feature flag

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/kubectl area/kubelet labels Oct 19, 2022
@apelisse apelisse mentioned this pull request Nov 8, 2022
Merged
@alexzielenski @Jefftree
negotiated refactor
76f0568 
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
@alexzielenski
Copy link
Contributor

squashed commits, all outstanding feedback believed to be addressed

/assign @apelisse

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2022
@Jefftree
Copy link
Member Author

Jefftree commented Nov 8, 2022

/retest

BenTheElder
BenTheElder reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for vendor/modules.txt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, deads2k, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
alexzielenski and others added 4 commits November 8, 2022 14:44
@alexzielenski @Jefftree
add new aggregated resourcemanager to genericapiserver
6e83f67 
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
@alexzielenski @Jefftree
add crds to aggregated discovery
1e3086b 
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
@alexzielenski @Jefftree
add aggregated-apiservices to aggregated discovery
b64df60 
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
@alexzielenski @Jefftree
add aggregated discovery integration tests
91d0d48 
Co-authored-by: Jeffrey Ying <jeffrey.ying86@live.com>
apelisse
apelisse reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@seans3
Copy link
Contributor

seans3 commented Nov 9, 2022

/milestone v1.26

This was approved and lgtm'ed well before the code freeze deadline. Hung up on a very long merge queue.

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 9, 2022 •
edited

@Jefftree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-conformance-image-test a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-conformance-image-test
pull-kubernetes-e2e-gce-storage-snapshot a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-capz-azure-file a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-ubuntu-gce-network-policies a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-e2e-capz-azure-disk-vmss a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-azure-disk-vmss
pull-kubernetes-e2e-capz-windows-containerd a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-windows-containerd
pull-kubernetes-e2e-gce-alpha-features a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gci-gce-ipvs a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gci-gce-ipvs
pull-kubernetes-e2e-gce-storage-slow a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-capz-conformance a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-conformance
pull-kubernetes-node-kubelet-credential-provider a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-node-kubelet-credential-provider
pull-kubernetes-e2e-gci-gce-ingress a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-e2e-capz-azure-disk a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-azure-disk
pull-kubernetes-e2e-capz-azure-file-vmss a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-capz-azure-file-vmss
pull-kubernetes-e2e-gce-csi-serial a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-kubelet-credential-provider a7d1f8c6fa4d34f1cbe0fa228cac80004b9f36bd link false /test pull-kubernetes-e2e-kubelet-credential-provider

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seans3
Copy link
Contributor

seans3 commented Nov 9, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8058e8e into kubernetes:master Nov 9, 2022
This was referenced Nov 14, 2022
Closed
Closed
@Jefftree Jefftree deleted the aggregated-discovery-generic branch December 2, 2022 18:48
@liggitt liggitt mentioned this pull request Jan 20, 2023
Merged
@pacoxu pacoxu mentioned this pull request Aug 8, 2023
Closed
@tamalsaha tamalsaha mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzielenski alexzielenski alexzielenski left review comments

@lavalamp lavalamp lavalamp left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@apelisse apelisse apelisse left review comments

@seans3 seans3 seans3 left review comments

@deads2k deads2k deads2k left review comments

@aojea aojea Awaiting requested review from aojea

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/stable-metrics Issues or PRs involving stable metrics area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet