Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-graceful node shutdown to beta #113511

Merged
merged 1 commit into from Nov 3, 2022
Merged

Move non-graceful node shutdown to beta #113511

merged 1 commit into from Nov 3, 2022

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Nov 1, 2022 •
edited

What type of PR is this?

Move non-graceful node shutdown (feature gate: NodeOutOfServiceVolumeDetach) to Beta.

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NodeOutOfServiceVolumeDetach is now beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

cc @sonasingh46

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

@xing-yang: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2022
@xing-yang
Copy link
Contributor Author

/sig storage
/sig node

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@dims
Copy link
Member

dims commented Nov 1, 2022

@xing-yang need to run hack/update-gofmt.sh

@xing-yang
Copy link
Contributor Author

/assign @jingxu97 @gnufied

@liggitt liggitt removed their request for review November 2, 2022 12:08
@xing-yang
Copy link
Contributor Author

/assign @msau42 @jsafrane

@gnufied
Copy link
Member

gnufied commented Nov 2, 2022

LGTM, but putting on hold so as @jingxu97 has a chance to review as well

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 2, 2022
@jingxu97
Copy link
Contributor

jingxu97 commented Nov 3, 2022

/lgtm

@xing-yang
Copy link
Contributor Author

@gnufied, @jingxu97 has added lgtm. Can you remove the hold? Thanks.

@gnufied
Copy link
Member

gnufied commented Nov 3, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d62cc3d into kubernetes:master Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
@xing-yang xing-yang mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin Awaiting requested review from thockin

Assignees

@gnufied gnufied

@jsafrane jsafrane

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xing-yang @k8s-ci-robot @dims @gnufied @jingxu97 @jsafrane @msau42