Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSRDuration feature gate. #112386

Merged
merged 1 commit into from Sep 12, 2022
Merged

Remove CSRDuration feature gate. #112386

merged 1 commit into from Sep 12, 2022

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Sep 12, 2022 •
edited

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Remove CSRDuration feature gate in v1.26, which graduated to GA in 1.24.

Which issue(s) this PR fixes:

Fixes #108814

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CSRDuration feature gate that graduated to GA in 1.24 and was unconditionally enabled has been removed in v1.26

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 12, 2022
@k8s-ci-robot
Copy link
Contributor

@Shubham82: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 12, 2022
@Shubham82 Shubham82 mentioned this pull request Sep 12, 2022
Closed
@Shubham82
Copy link
Contributor Author

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 12, 2022
@Shubham82
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 12, 2022
@Shubham82
Copy link
Contributor Author

Hi @lavalamp, @smarterclayton
PTAL!

@Shubham82
Copy link
Contributor Author

I will open a pr in k8s/website to remove it from Feature Gates docs.

@enj
Copy link
Member

enj commented Sep 12, 2022

I will open a pr in k8s/website to remove it from Feature Gates docs.

That page is autogenerated so a manual PR is not required.

@enj
Copy link
Member

enj commented Sep 12, 2022

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@enj
Copy link
Member

enj commented Sep 12, 2022

Release note comment needs release-note language type.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 12, 2022
@Shubham82
Copy link
Contributor Author

I will open a pr in k8s/website to remove it from Feature Gates docs.

That page is autogenerated so a manual PR is not required.

Hi @enj
I think this page is not autogenerated, there is no auto_generated: true tag on this page
unlike in other autogenerated pages for example: kube-apiserver.md

To update anything here we have to do it manually.

@liggitt
Copy link
Member

liggitt commented Sep 12, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@enj
Copy link
Member

enj commented Sep 12, 2022

I will open a pr in k8s/website to remove it from Feature Gates docs.

That page is autogenerated so a manual PR is not required.

Hi @enj
I think this page is not autogenerated, there is no auto_generated: true tag on this page
unlike in other autogenerated pages for example: kube-apiserver.md

To update anything here we have to do it manually.

You are welcome to open a PR but generally the docs team handles updating that page at release time (I believe they parse the feature gates with a script).

@Shubham82
Copy link
Contributor Author

I will open a pr in k8s/website to remove it from Feature Gates docs.

That page is autogenerated so a manual PR is not required.

Hi @enj
I think this page is not autogenerated, there is no auto_generated: true tag on this page
unlike in other autogenerated pages for example: kube-apiserver.md
To update anything here we have to do it manually.

You are welcome to open a PR but generally the docs team handles updating that page at release time (I believe they parse the feature gates with a script).

Sure, I will confirm with docs team about it.
Thanks

@Shubham82
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 72f96d9 into kubernetes:master Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 12, 2022
@Shubham82 Shubham82 mentioned this pull request Sep 14, 2022
Merged
@SataQiu SataQiu mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Remove the "CSRDuration" feature gate in Kube v1.26
4 participants
@Shubham82 @k8s-ci-robot @enj @liggitt