Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112026: upgrade system-validators to v1.8.0 for a bugfix of cgroupv2 #114059

Merged
merged 1 commit into from Dec 27, 2022
Merged

Automated cherry pick of #112026: upgrade system-validators to v1.8.0 for a bugfix of cgroupv2 #114059

merged 1 commit into from Dec 27, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Nov 22, 2022 •
edited

Cherry pick of #112026 on release-1.25.

#112026: upgrade system-validators to v1.8.0 for a bugfix of cgroupv2

For details on the cherry pick process, see the cherry pick requests page.

update the system-validators library to v1.8.0

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from lavalamp, logicalhan and a team November 22, 2022 07:12
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 22, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Nov 22, 2022

/kind bug
/sig cluster-lifecycle
/cc @neolit123 @dims

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Nov 22, 2022

This fixes a wrong warning. Without this cherry-pick, there would be a warning during kubeadm init/join preflight.

@pacoxu pacoxu mentioned this pull request Nov 22, 2022
Closed
neolit123
neolit123 reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/kind bug

i am ok with this backport as the warning can be considered a bug, but not a critical one as it's only a warning.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 17, 2022

/assign @liggitt
for approval

@liggitt
Copy link
Member

liggitt commented Dec 19, 2022 •
edited

leaning on kubeadm reviewer for lgtm

/approve
for dependency update

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@neolit123
Copy link
Member

/lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Dec 20, 2022

/cc kubernetes/release-managers

@xmudrii
Copy link
Member

xmudrii commented Dec 26, 2022

@pacoxu Do we need to cherry-pick this PR to the release-1.23 branch?

@xmudrii xmudrii mentioned this pull request Dec 26, 2022
Closed
@pacoxu
Copy link
Member Author

pacoxu commented Dec 27, 2022

@pacoxu Do we need to cherry-pick this PR to the release-1.23 branch?

The issue is introduced in system-validator v1.7.0 (kubernetes/system-validators#29).

  • release v1.23 is using system-validator v1.6.0. So we don't need to cherry-pick it to the release-1.23 branch.

xmudrii
xmudrii approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 27, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, neolit123, pacoxu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 481e774 into kubernetes:release-1.25 Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@xmudrii xmudrii xmudrii approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@logicalhan logicalhan Awaiting requested review from logicalhan

@dims dims Awaiting requested review from dims

Assignees

@neolit123 neolit123

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacoxu @k8s-ci-robot @liggitt @neolit123 @xmudrii