Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Azure File CSI migration as GA in 1.26 #113160

Merged
merged 1 commit into from Nov 7, 2022
Merged

make Azure File CSI migration as GA in 1.26 #113160

merged 1 commit into from Nov 7, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 19, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

make Azure File CSI migration as GA in 1.26

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @msau42 @xing-yang
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

Does this PR introduce a user-facing change?

make Azure File CSI migration as GA in 1.26

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

make Azure File CSI migration as GA in 1.26

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 19, 2022
@andyzhangx
Copy link
Member Author

/retest

@bertinatto
Copy link
Member

@andyzhangx @gnufied @jsafrane @xing-yang
Should we hold this until we promote FSGroup to GA?

@bertinatto
Copy link
Member

@andyzhangx, the release note in the PR description seems incorrect, it should be GA in 1.26.

@andyzhangx
Copy link
Member Author

@andyzhangx @gnufied @jsafrane @xing-yang Should we hold this until we promote FSGroup to GA?

@bertinatto per kubernetes/enhancements#3550, fsgroup mount should be also GA in 1.26, so it's good to go?

@andyzhangx
Copy link
Member Author

cc @bridgetkromhout

@bertinatto
Copy link
Member

@andyzhangx @gnufied @jsafrane @xing-yang Should we hold this until we promote FSGroup to GA?

@bertinatto per kubernetes/enhancements#3550, fsgroup mount should be also GA in 1.26, so it's good to go?

That's correct, FSGroup mount will be GA in 1.26, however, the code changes haven't been made yet.

@andyzhangx
Copy link
Member Author

@gnufied

@gnufied are you going to make fsgroup mount GA change? thanks.

@gnufied
Copy link
Member

gnufied commented Oct 20, 2022

@bertinatto is working on it - #113225

jsafrane
jsafrane reviewed Nov 4, 2022
View reviewed changes
pkg/features/kube_features.go
@@ -824,7 +825,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

CSIMigrationAzureDisk: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // On by default in 1.23 (requires Azure Disk CSI driver)

CSIMigrationAzureFile: {Default: true, PreRelease: featuregate.Beta}, // On by default in 1.24 (requires Azure File CSI driver)
CSIMigrationAzureFile: {Default: true, PreRelease: featuregate.GA}, // On by default in 1.24 (requires Azure File CSI driver)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment remove in 1.28

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better, replace the existing comment with // remove in 1.28

@jsafrane
Copy link
Member

jsafrane commented Nov 4, 2022

FSGroup mount is GA!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@dims
Copy link
Member

dims commented Nov 5, 2022

@andyzhangx looks like one suggestion in there about a comment when to remove the flag. can you please do that?

@jsafrane
Copy link
Member

jsafrane commented Nov 7, 2022

Andy is on PTO, I'll fix the comment in a subsequent PR
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@xing-yang
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7cd98de into kubernetes:master Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 7, 2022
This was referenced Nov 8, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andyzhangx @bertinatto @gnufied @jsafrane @k8s-ci-robot @dims @xing-yang @msau42