Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove unused flags from kubectl run" #112243

Merged
merged 1 commit into from Sep 5, 2022
Merged

Revert "Remove unused flags from kubectl run" #112243

merged 1 commit into from Sep 5, 2022

Conversation

brianpursley
Copy link
Member

@brianpursley brianpursley commented Sep 5, 2022 •
edited by liggitt

The original PR removed flags which were not use by kubectl run. They were ignored if set.

However, the removal of those flags would be a breaking change for someone who happened to be setting them because it would result in an "unknown flag" error. Their removal needs to follow the deprecation process.

Reverts #110668

Does this PR introduce a user-facing change?

Fixes a 1.25 regression where unused flags in the `kubectl run` command were removed before going through the required deprecation period.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2022
soltysh
soltysh approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

saschagrunert commented Sep 5, 2022 •
edited

Please note that the revert needs to be cherry-picked into release-1.25 if merged.

@soltysh
Copy link
Contributor

soltysh commented Sep 5, 2022

/triage accepted
/priority important-longterm
/kind regression

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 5, 2022
@soltysh
Copy link
Contributor

soltysh commented Sep 5, 2022

Please note that the revert needs to be cherry-picked into release-1.25 if merged.

That's the plan.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2022
@brianpursley
Copy link
Member Author

pull-kubernetes-node-e2e-containerd succeeded, but remained in Pending status for a couple of hours. I clicked Rerun on that job, so hopefully it will recognize it as succeeded this time.

@k8s-ci-robot k8s-ci-robot merged commit 67bde9a into kubernetes:master Sep 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 5, 2022
@brianpursley brianpursley mentioned this pull request Sep 5, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 5, 2022
@k8s-ci-robot
Merge pull request #112249 from brianpursley/automated-cherry-pick-of…
cff6139 
…-#112243-upstream-release-1.25

Automated cherry pick of #112243: Revert "Remove unused flags from kubectl run"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dougsland dougsland Awaiting requested review from dougsland

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianpursley @k8s-ci-robot @saschagrunert @soltysh