New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove unused flags from kubectl run" #112243
Revert "Remove unused flags from kubectl run" #112243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please note that the revert needs to be cherry-picked into release-1.25 if merged. |
/triage accepted |
That's the plan. |
pull-kubernetes-node-e2e-containerd succeeded, but remained in Pending status for a couple of hours. I clicked Rerun on that job, so hopefully it will recognize it as succeeded this time. |
…-#112243-upstream-release-1.25 Automated cherry pick of #112243: Revert "Remove unused flags from kubectl run"
The original PR removed flags which were not use by
kubectl run
. They were ignored if set.However, the removal of those flags would be a breaking change for someone who happened to be setting them because it would result in an "unknown flag" error. Their removal needs to follow the deprecation process.
Reverts #110668
Does this PR introduce a user-facing change?