Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick pr #111557 to 1.24 :update smd to 4.2.3 #111915

Merged
merged 2 commits into from Jan 12, 2023
Merged

cherry pick pr #111557 to 1.24 :update smd to 4.2.3 #111915

merged 2 commits into from Jan 12, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 18, 2022 •
edited by liggitt

/kind bug
/sig api-machinery

Includes dependency bump from #111557 and test from #111912

Fix performance issue when creating large objects using SSA with fully unspecified schemas (preserveUnknownFields).

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/test labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot requested review from ahg-g, brianpursley and a team August 18, 2022 15:27
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 18, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2022
@apelisse
Copy link
Member

That actually backports another bug fix that is totally fine, thanks!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2022
@enj enj added this to Needs Triage in SIG Auth Old Sep 12, 2022
@aojea
Copy link
Member Author

aojea commented Oct 11, 2022

ping @kubernetes/release-managers

@xmudrii xmudrii mentioned this pull request Oct 11, 2022
Merged
@aojea
Copy link
Member Author

aojea commented Oct 11, 2022

@apelisse it needs lgtm label

@apelisse
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@aojea
Copy link
Member Author

aojea commented Nov 7, 2022

ping @kubernetes/release-managers

@saschagrunert
Copy link
Member

Ref: #111914 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 29, 2022
@aojea
Copy link
Member Author

aojea commented Nov 29, 2022

New changes are detected. LGTM label has been removed.

ping @kubernetes/release-managers the lgtm was removed during the rebase

@aojea
Copy link
Member Author

aojea commented Dec 2, 2022

/retest

@dims
Copy link
Member

dims commented Dec 12, 2022

If you still need this PR then please rebase, if not, please close the PR

@aojea
Copy link
Member Author

aojea commented Jan 11, 2023

@liggitt this keeps slipping releases :/

@liggitt
Copy link
Member

liggitt commented Jan 11, 2023

/lgtm
/approve

can you reach out to the release managers in slack to make sure this is on their radar for January releases?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e57fc59ecf5a4a8b3d8a91be3196a8798c57979

@liggitt
Copy link
Member

liggitt commented Jan 11, 2023

/test pull-kubernetes-dependencies

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Verolop
Copy link

Verolop commented Jan 12, 2023

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit aeb26cd into kubernetes:release-1.24 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees

@liggitt liggitt

@apelisse apelisse

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
[sig-architecture] Dependency management
Status: Done
SIG Auth Old
Needs Triage
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aojea @leilajal @liggitt @apelisse @saschagrunert @dims @k8s-ci-robot @Verolop