Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore in-tree credential plugins for 1.25 #111918

Merged
merged 3 commits into from Aug 18, 2022
Merged

Restore in-tree credential plugins for 1.25 #111918

merged 3 commits into from Aug 18, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 18, 2022

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Reverts #110013 to avoid regressions from migrating to exec auth (#111911, kubernetes/kubectl#1128)

Additional commits:

Does this PR introduce a user-facing change?

The `gcp` and `azure` auth plugins have been restored to client-go and kubectl until https://issue.k8s.io/111911 is resolved in supported kubectl minor versions.

/sig auth
/milestone v1.25
/cc @enj

@k8s-ci-robot k8s-ci-robot requested a review from enj August 18, 2022 18:22
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 18 13:40:40 UTC 2022.

@k8s-ci-robot k8s-ci-robot added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 18, 2022
@liggitt liggitt mentioned this pull request Aug 18, 2022
Closed
@cici37
Copy link
Contributor

cici37 commented Aug 18, 2022

/lgtm
from release team. Thank you for the PR!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2022
@liggitt
Copy link
Member Author

liggitt commented Aug 18, 2022

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2022
@dims
Copy link
Member

dims commented Aug 18, 2022

/approve
/lgtm

@cici37 cici37 mentioned this pull request Aug 18, 2022
Merged
@dims
Copy link
Member

dims commented Aug 18, 2022

/test check-dependency-stats

@enj
Copy link
Member

enj commented Aug 18, 2022

/lgtm
/approve

image

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Member

enj commented Aug 18, 2022

xref: #111911 (comment)

@k8s-ci-robot k8s-ci-robot merged commit d581cc9 into kubernetes:master Aug 18, 2022
@liggitt liggitt deleted the in-tree-auth branch August 18, 2022 19:51
This was referenced Aug 18, 2022
Merged
Merged
This was referenced Aug 26, 2022
Closed
Closed
@mjhilton mjhilton mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

Assignees

@dims dims

@enj enj

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @cici37 @dims @enj