Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #113776: Creating Ingress IP loadbalancer alone when all the endpoints #114451

Merged
merged 1 commit into from Dec 15, 2022
Merged

Automated cherry pick of #113776: Creating Ingress IP loadbalancer alone when all the endpoints #114451

merged 1 commit into from Dec 15, 2022

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented Dec 13, 2022 •
edited

Cherry pick of #113776 on release-1.24.

#113776: Creating Ingress IP loadbalancer alone when all the endpoints

For details on the cherry pick process, see the cherry pick requests page.

Fixing issue with Winkernel Proxier - No ingress load balancer rules with endpoints to support load balancing when all the endpoints are terminating.

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2022
@princepereira princepereira force-pushed the automated-cherry-pick-of-#113776-upstream-release-1.24 branch from 9c3edca to f556708 Compare December 13, 2022 14:06
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 13, 2022
@princepereira
Copy link
Contributor Author

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2022
@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2022
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-typecheck

@princepereira princepereira force-pushed the automated-cherry-pick-of-#113776-upstream-release-1.24 branch from f556708 to b7eae4d Compare December 14, 2022 13:01
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-unit

1 similar comment
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-unit

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

1 similar comment
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@sbangari
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princepereira, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2022
@sbangari
Copy link
Contributor

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team December 14, 2022 22:44
@mainred
Copy link

mainred commented Dec 15, 2022 •
edited

@cpanato @xmudrii could you please take a look at our cherry-pick PR? we have customers hitting this issue, thanks.

@Verolop
Copy link

Verolop commented Dec 15, 2022

/lgtm

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-containerd-1-24
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2022
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5b3592e into kubernetes:release-1.24 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@sbangari sbangari Awaiting requested review from sbangari

Assignees

@Verolop Verolop

@sbangari sbangari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@princepereira @k8s-ci-robot @feiskyer @sbangari @mainred @Verolop @marosset