New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: pass etcd progress notification flag to etcd #111383
kubeadm: pass etcd progress notification flag to etcd #111383
Conversation
/assign @neolit123 @aojea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr. i think you need to run ./hack/update-gofmt.sh first.
/approve
/triage accepted
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
The experimental-watch-progress-notify-interval flag specifies an interval at which etcd sends data to the kube-api server. It is used by the WatchBookmark feature which is GA since 1.17. It will be used by a new WatchList feature which is Alpha since 1.25 In addition to that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes
caf7201
to
81dec8b
Compare
I did, plus |
/lgtm |
awesome 👏 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The experimental-watch-progress-notify-interval flag specifies an interval
at which etcd sends data to the kube-api server.
It is used by the WatchBookmark feature which is GA since 1.17.
It will be used by a new WatchList feature which is Alpha since 1.25
In addition to that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes
Which issue(s) this PR fixes:
xref: kubernetes/kubeadm#2731
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: