Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: Fixes plugin Watcher for Windows #111439

Merged
merged 1 commit into from Jul 30, 2022
Merged

kubelet: Fixes plugin Watcher for Windows #111439

merged 1 commit into from Jul 30, 2022

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Currently, the plugin Watcher checks if a file is a socket or not by running mode&os.ModeSocket != 0, which can't be True on Windows.

util.IsUnixDomainSocket should be used instead, which has a Windows implementation.

Which issue(s) this PR fixes:

Fixes #111438
Related: #51540

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Windows kubelet plugin Watcher now working as intended.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 26, 2022
@claudiubelu
kubelet: Fixes plugin Watcher for Windows
f567b85 
Currently, the plugin Watcher checks if a file is a socket or not by
running mode&os.ModeSocket != 0, which can't be True on Windows.

util.IsUnixDomainSocket should be used instead.
@marosset
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 26, 2022
@claudiubelu
Copy link
Contributor Author

/sig windows
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2022
@marosset
Copy link
Contributor

/sig windows

@jsturtevant
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2022
@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-containerd

@jsturtevant
Copy link
Contributor

Can we also fix the unit test here where this was found?

/priority important soon

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The label(s) priority/important, priority/soon cannot be applied, because the repository doesn't have them.

In response to this:

Can we also fix the unit test here where this was found?

/priority important soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 26, 2022
@marosset marosset added this to In Review (v1.25) in SIG-Windows Jul 28, 2022
@marosset
Copy link
Contributor

/lgtm
/assign @saad-ali

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2022
@marosset marosset moved this from In Review (v1.25) to Reviewed - Needs Approval From Other SIGs in SIG-Windows Jul 28, 2022
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2022
@dchen1107 dchen1107 added kind/bug Categorizes issue or PR as related to a bug. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 30, 2022
@dchen1107
Copy link
Member

/approve again

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 25cdacc into kubernetes:master Jul 30, 2022
SIG-Windows automation moved this from Reviewed - Needs Approval From Other SIGs to Done (v1.25) Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@dchen1107 dchen1107

@saad-ali saad-ali

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.25)
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

kubelet: The Plugin Watcher not working as intended on Windows
6 participants
@claudiubelu @marosset @jsturtevant @k8s-ci-robot @dchen1107 @saad-ali