Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Kubelet Credential Provider feature to GA and Update the Credential Provider API to GA #111616

Merged
merged 13 commits into from Oct 15, 2022
Merged

Move the Kubelet Credential Provider feature to GA and Update the Credential Provider API to GA #111616

merged 13 commits into from Oct 15, 2022
+1,308 −29

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented Aug 1, 2022 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Move the Kubelet Credential Provider feature to GA and Update the Credential Provider API to GA

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubelet external Credential Provider feature is moved to GA. Credential Provider Plugin and Credential Provider Config APIs updated from v1beta1 to v1 with no API changes.

e2e test added in #111495 needs to merge first to meet GA requirements
e2e test configured in kubernetes/test-infra#27724

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2133-kubelet-credential-providers

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ndixita. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 1, 2022
@ndixita ndixita force-pushed the credential-api-ga branch 4 times, most recently from abf6fa2 to 452962d Compare August 2, 2022 00:13
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 2, 2022
@ndixita
Copy link
Contributor Author

ndixita commented Aug 2, 2022

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 2, 2022
@ndixita ndixita changed the title Credential api ga Move the Kubelet Credential Provider feature to GA and Update the Credential Provider API to GA Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 2, 2022
@dims
Copy link
Member

dims commented Oct 5, 2022

/retest

@ndixita ndixita requested review from liggitt and andrewsykim and removed request for liggitt October 10, 2022 21:31
@ndixita
Copy link
Contributor Author

ndixita commented Oct 14, 2022

/assign @mrunalp
/assign @nikhita

@ndixita ndixita requested a review from liggitt October 14, 2022 07:27
@liggitt
Copy link
Member

liggitt commented Oct 14, 2022 •
edited

lgtm once the test-infra PR merges and we get a successful presubmit run of it on this PR

@dims
Copy link
Member

dims commented Oct 14, 2022

@ndixita the test-infra PR should land shortly. please try the pull-kubernetes-e2e-kubelet-credential-provider on this PR as well, to see if it works fine.

@andrewsykim
Copy link
Member

/test pull-kubernetes-node-kubelet-credential-provider

@andrewsykim
Copy link
Member

/test pull-kubernetes-e2e-kubelet-credential-provider

@andrewsykim
Copy link
Member

Looks like the job is running, thanks @ndixita!

@andrewsykim
Copy link
Member

andrewsykim commented Oct 14, 2022 •
edited

@ndixita I think there's a follow-up item here to update cloud-provider-gcp to use v1 after this PR lands: https://github.com/kubernetes/cloud-provider-gcp/blob/master/cmd/auth-provider-gcp/provider/provider.go#L28.

Or at the very least v1beta1, since it may not be possible to vendor latest kubelet API there

@dims
Copy link
Member

dims commented Oct 14, 2022

nice!

/approve

@liggitt
Copy link
Member

liggitt commented Oct 15, 2022

/approve

thanks for adding the test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, ndixita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2022
@liggitt
Copy link
Member

liggitt commented Oct 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6f579d3 into kubernetes:master Oct 15, 2022
SIG Node CI/Test Board automation moved this from Archive-it to Done Oct 15, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Oct 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 15, 2022
@ruiwen-zhao
Copy link
Contributor

For tracking purposes, this PR is for kubernetes/enhancements#2133

@pacoxu pacoxu mentioned this pull request Mar 24, 2023
Merged
@ndixita ndixita mentioned this pull request Apr 4, 2023
Closed
9 tasks
@ikolomiyets ikolomiyets mentioned this pull request Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@ruiwen-zhao ruiwen-zhao ruiwen-zhao left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@mrunalp mrunalp

@liggitt liggitt

@ruiwen-zhao ruiwen-zhao

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.26
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ndixita @k8s-ci-robot @liggitt @ruiwen-zhao @fedebongio @cici37 @dims @andrewsykim @mrunalp @nikhita