New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apimachinery meta errors: Support errors.Is and error wrapping #111808
Conversation
@alvaroaleman: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 11 19:31:32 UTC 2022. |
/sig api-machinery |
Currently, the errors in the pkg/api/meta package don't work correctly with the stdlibs `errors.Is` because they do not implement an `Is` method, which makes the matching fall through to use reflect to check for equality. This change fixes that and as a side-effect also adds support to match on wrapped errors.
20d1f64
to
b285bee
Compare
Looks fine to me, I'll also let someone else approve. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you Antoine and Alex! |
/assign @deads2k for final approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, alvaroaleman, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, the errors in the pkg/api/meta package don't work correctly
with the stdlibs
errors.Is
because they do not implement anIs
method, which makes the matching fall through to use reflect to check
for equality. This change fixes that and as a side-effect also adds
support to match on wrapped errors.
What type of PR is this?
/kind bug
/sig api-machinery
/cc @lavalamp @apelisse @alexzielenski
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: