Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cAdvisor to v0.44.1 #109658

Merged
merged 1 commit into from Apr 26, 2022
Merged

Bump cAdvisor to v0.44.1 #109658

merged 1 commit into from Apr 26, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Apr 26, 2022 •
edited

Bump cAdvisor to v0.44.1 to pick up fix for containerd task timeout
which resulted in empty network metrics.

Signed-off-by: David Porter david@porter.me

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #109082

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated to cAdvisor v0.44.1 to fix an issue where metrics generated by kubelet for pod network stats were empty in some cases

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@bobbypage
Bump cAdvisor to v0.44.1
b0da29d 
Bump cAdvisor to v0.44.1 to pick up fix for containerd task timeout
which resulted in empty network metrics.

Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2022
@bobbypage
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2022
@bobbypage
Copy link
Member Author

/cc @SergeyKanzhelev @ruiwen-zhao @dims @mikebrow @aojea

@bobbypage
Copy link
Member Author

Picks up fix from cAdvisor - google/cadvisor#3105

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot requested review from logicalhan and a team April 26, 2022 00:22
@bobbypage bobbypage mentioned this pull request Apr 26, 2022
Closed
@dims
Copy link
Member

dims commented Apr 26, 2022

/approve
/lgtm

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2022
@liggitt
Copy link
Member

liggitt commented Apr 26, 2022 •
edited

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

/retest

@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 26, 2022
@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

probably worth a release note

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2022
@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

are we expecting this in 1.24.0 or 1.24.1?

@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

/retest

@dims
Copy link
Member

dims commented Apr 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit a83cc51 into kubernetes:master Apr 26, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.24, v1.25 Apr 26, 2022
@liggitt
Copy link
Member

liggitt commented Apr 26, 2022

needs to be cherry-picked to release-1.24 to make it into the 1.24 release

@bobbypage bobbypage mentioned this pull request Apr 26, 2022
Merged
@bobbypage
Copy link
Member Author

Opened cherrypick to release-1.24 here - #109675

@jberkus
Copy link

jberkus commented Apr 26, 2022

This is a dependency version number change, and it's being added to 1.24, so I believe it does need a release note.

@AuraSinis

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 26, 2022
@bobbypage
Copy link
Member Author

Added release note, PTAL.

@AuraSinis
Copy link

Oh cool you fixed it! I'll make sure the RN is added.

@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Open
k8s-ci-robot added a commit that referenced this pull request Apr 28, 2022
@k8s-ci-robot
Merge pull request #109675 from bobbypage/automated-cherry-pick-of-#1…
cd616dd 
…09658-upstream-release-1.24

Automated cherry pick of #109658: Bump cAdvisor to v0.44.1
@111andre111 111andre111 mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dims dims Awaiting requested review from dims

@mikebrow mikebrow Awaiting requested review from mikebrow

@ruiwen-zhao ruiwen-zhao Awaiting requested review from ruiwen-zhao

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

[sig-node] Summary API [NodeConformance] when querying /stats/summary ... networking info is nil on containerd
6 participants
@bobbypage @k8s-ci-robot @dims @liggitt @jberkus @AuraSinis