Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate LegacyServiceAccountTokenNoAutoGeneration to ga #112838

Merged
merged 1 commit into from Nov 2, 2022
Merged

graduate LegacyServiceAccountTokenNoAutoGeneration to ga #112838

merged 1 commit into from Nov 2, 2022

Conversation

zshihang
Copy link
Contributor

@zshihang zshihang commented Oct 3, 2022 •
edited by liggitt

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change?

The LegacyServiceAccountTokenNoAutoGeneration feature gate has been promoted to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/2799-reduction-of-secret-based-service-account-token

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 3, 2022
@zshihang
Copy link
Contributor Author

zshihang commented Oct 3, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2022
@zshihang
Copy link
Contributor Author

zshihang commented Oct 3, 2022

/cc @liggitt

@liggitt
Copy link
Member

liggitt commented Oct 4, 2022

it looks like some providers still disable this - https://grep.app/search?q=LegacyServiceAccountTokenNoAutoGeneration%3Dfalse

before removing autogeneration support, it would be good to understand why, and what their timeframe is for enabling the feature

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2022
@zshihang
Copy link
Contributor Author

zshihang commented Oct 4, 2022

there is only one code reference in https://grep.app/search?q=LegacyServiceAccountTokenNoAutoGeneration%3Dfalse. according to Azure/aks-engine#4890 (comment), that will not be supported in 1.25+; others are markdown files.

@liggitt
Copy link
Member

liggitt commented Oct 4, 2022

hmm, I still think the following uses need to be understood (especially the ones where kubernetes projects are disabling the feature gate in tests):

@zshihang
Copy link
Contributor Author

zshihang commented Oct 4, 2022

not sure about this one. couldn't find any owners on this file.

seems these windows testing files were requiring the feature gate disabled due to the legacy aks-engine, which will not be supported in 1.25+ per last comment. @marosset to confirm since you authored the relevant PRs.

@marosset
Copy link
Contributor

marosset commented Oct 4, 2022

not sure about this one. couldn't find any owners on this file.

seems these windows testing files were requiring the feature gate disabled due to the legacy aks-engine, which will not be supported in 1.25+ per last comment. @marosset to confirm since you authored the relevant PRs.

aks-engine was on life-support during v1.24 and is now deprecated. Because of that we opted to just disable to feature for v1.24 clusters used to run Windows e2e tests and I didn't go very deep into understanding what was actually failing.

Since the deprecation of aks-engine - all of the Windows e2e tests that were running on aks-engine have been migrated to CAPZ and we do not have this feature disabled for any of the CAPZ clusters.

@mboersma
Copy link
Contributor

mboersma commented Oct 5, 2022

I don't remember the specific error, but we were unable to provision new clusters with the new behavior, so I enabled the legacy flag in Azure/aks-engine#4890.

@zshihang
Copy link
Contributor Author

zshihang commented Oct 5, 2022

so the 1.25 tests don't need to disable the feature gate? in other words, this pr has no impact on your tests

@mboersma
Copy link
Contributor

mboersma commented Oct 5, 2022

so the 1.25 tests don't need to disable the feature gate?

In our specific case (AKS Engine), the product is deprecated and will never support v1.25. So that made enabling the legacy behavior justifiable.

@zshihang
Copy link
Contributor Author

zshihang commented Oct 6, 2022

@liggitt any other cases we need to figure out before merging this PR?

@enj enj added this to Needs Triage in SIG Auth Old Oct 10, 2022
@sftim
Copy link
Contributor

sftim commented Oct 10, 2022

Does this PR need a release note?

@liggitt
Copy link
Member

liggitt commented Oct 10, 2022

@liggitt any other cases we need to figure out before merging this PR?

I'm satisfied that the controller itself is stable with the gate off, so I think promoting it to GA in 1.26 is reasonable.

I'd probably wait to lock it on until 1.23 is no longer supported, to ensure all supported clusters have encountered the feature gate in 1.24 and made plans to adjust to use tokenrequest or explicitly request secrets, and given feedback on the change.

@zshihang
Copy link
Contributor Author

i couldn't recall a feature that can be disabled in GA (without lock).

in most scenarios, a cluster will not jump version when upgrading. so mostly they will have two releases to make plans before upgrading to 1.26 (locked). the question comes down to how many releases are we comfortable with.

@deads2k
Copy link
Contributor

deads2k commented Oct 11, 2022

I'm satisfied that the controller itself is stable with the gate off, so I think promoting it to GA in 1.26 is reasonable.

I'd probably wait to lock it on until 1.23 is no longer supported, to ensure all supported clusters have encountered the feature gate in 1.24 and made plans to adjust to use tokenrequest or explicitly request secrets, and given feedback on the change.

Both of those boundaries seem good to me.

@liggitt
Copy link
Member

liggitt commented Oct 11, 2022

I'd probably wait to lock it on until 1.23 is no longer supported

concretely, that's in ~Feb 2023, so in time for 1.27 (https://kubernetes.io/releases/patch-releases/#1-23)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2022
@liggitt
Copy link
Member

liggitt commented Oct 31, 2022

go ahead and scope this PR to promoting the feature gate to GA, and plan to lock it on in 1.27

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 1, 2022
@liggitt
Copy link
Member

liggitt commented Nov 2, 2022

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@zshihang
Copy link
Contributor Author

zshihang commented Nov 2, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 32ea818 into kubernetes:master Nov 2, 2022
SIG Auth Old automation moved this from Needs Triage to Closed / Done Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 2, 2022
@zshihang zshihang mentioned this pull request Dec 14, 2022
Closed
39 tasks
@ialidzhikov ialidzhikov mentioned this pull request Dec 19, 2022
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@zshihang @liggitt @marosset @jackfrancis @mboersma @sftim @deads2k @k8s-ci-robot