Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade system-validators to v1.8.0 for a bugfix of cgroupv2 io check #112026

Merged
merged 1 commit into from Aug 25, 2022
Merged

upgrade system-validators to v1.8.0 for a bugfix of cgroupv2 io check #112026

merged 1 commit into from Aug 25, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 25, 2022 •
edited by k8s-ci-robot

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes kubernetes/system-validators#31

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update the system-validators library to v1.8.0

/cc @neolit123

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Aug 25, 2022
@neolit123
Copy link
Member

/release-note-edit

update the system-validators library to v1.8.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 25, 2022
@neolit123
Copy link
Member

/lgtm
/approve

@neolit123
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Aug 25, 2022

/assign dims

@dims
Copy link
Member

dims commented Aug 25, 2022

/approve
/lgtm

/assign @liggitt @thockin
(for root OWNERS approval)

@liggitt
Copy link
Member

liggitt commented Aug 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 0a879aa link unknown /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member Author

pacoxu commented Aug 25, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7627791 into kubernetes:master Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 25, 2022
@dims dims mentioned this pull request Nov 21, 2022
Closed
This was referenced Nov 22, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 27, 2022
@k8s-ci-robot
Merge pull request #114060 from pacoxu/automated-cherry-pick-of-#1120…
2124e5f 
…26-upstream-release-1.24

Automated cherry pick of #112026: upgrade system-validators to v1.8.0 for a bugfix of cgroupv2
k8s-ci-robot added a commit that referenced this pull request Dec 27, 2022
@k8s-ci-robot
Merge pull request #114059 from pacoxu/automated-cherry-pick-of-#1120…
481e774 
…26-upstream-release-1.25

Automated cherry pick of #112026: upgrade system-validators to v1.8.0 for a bugfix of cgroupv2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@dims dims

@neolit123 neolit123

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

kubeadm shows SystemVerification warning about "missing optional cgroups: blkio"
6 participants
@pacoxu @k8s-ci-robot @neolit123 @dims @liggitt @thockin