New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote ExpandedDNSConfig feature to beta stage #112824
Promote ExpandedDNSConfig feature to beta stage #112824
Conversation
@gjkim42: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0360ad5
to
5fcdde0
Compare
/retest |
5fcdde0
to
1098ff6
Compare
I wouldn't list container runtime support in the release note: we try not to pick favorites, and I'd rather not try to produce a definitive list of container runtimes that include the necessary support. If we do add a definitive list, we need to make sure that it remains in alphabetical order. We don't have project guidance on 3rd party software mentions in release notes, but https://github.com/cncf/foundation/blob/main/website-guidelines.md is along similar lines. It's OK to publish a blog article for the release where this graduates to beta, and mention compatible runtime examples in that blog article.
|
This adds an e2e test for the feature and promotes ExpandedDNSConfig feature to the beta stage.
1098ff6
to
add4652
Compare
removed the container runtime list from the release note. And removed WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjkim42, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds an e2e test for
ExpandedDNSConfig
and promotes KEP 2595 (Expanded DNS Configuration) to the beta stage.ref: kubernetes/enhancements#2884
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: