Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Updated to v3.5.5 #112489

Merged
merged 1 commit into from Sep 16, 2022
Merged

etcd: Updated to v3.5.5 #112489

merged 1 commit into from Sep 16, 2022

Conversation

dims
Copy link
Member

@dims dims commented Sep 15, 2022 •
edited

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Update etcd to v3.5.5.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

etcd: Update to v3.5.5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm labels Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/test needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2022
@dims
etcd: Updated to v3.5.5
0f6b9b8 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2022
@dims dims changed the title [WIP] etcd: Updated to v3.5.5 etcd: Updated to v3.5.5 Sep 16, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@dims
Copy link
Member Author

dims commented Sep 16, 2022

/assign @jpbetz @serathius @neolit123

1 similar comment
@dims
Copy link
Member Author

dims commented Sep 16, 2022

/assign @jpbetz @serathius @neolit123

@dims
Copy link
Member Author

dims commented Sep 16, 2022

/retest

@pacoxu
Copy link
Member

pacoxu commented Sep 16, 2022 •
edited

We can /retest after kubernetes/k8s.io#4222 is merged.

Current failure messages:

Sep 16 02:35:25 kind-control-plane kubelet[285]: E0916 02:35:25.179454 285 remote_image.go:242] "PullImage from image service failed" err="rpc error: code = NotFound desc = failed to pull and unpack image "registry.k8s.io/etcd:3.5.5-0": failed to resolve reference "registry.k8s.io/etcd:3.5.5-0": registry.k8s.io/etcd:3.5.5-0: not found" image="registry.k8s.io/etcd:3.5.5-0"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Sep 16, 2022

/retest

@dims
Copy link
Member Author

dims commented Sep 16, 2022

/priority important-soon

@ameukam
Copy link
Member

ameukam commented Sep 16, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 06fd0a0 into kubernetes:master Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 16, 2022
@ahrtr
Copy link
Member

ahrtr commented Sep 16, 2022

Please note that there are also bug fixes on clientv3 in 3.5.5, so you might want to bump etcd-client dependencies as well. e.g go.mod/go.sum

@warmchang
Copy link
Contributor

ref: #112545

@warmchang warmchang mentioned this pull request Sep 18, 2022
Closed
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 20, 2022
@ahrtr ahrtr mentioned this pull request Sep 22, 2022
Closed
This was referenced Oct 17, 2022
Merged
Merged
Closed
@pacoxu pacoxu mentioned this pull request Oct 20, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 21, 2022
@k8s-ci-robot
Merge pull request #113197 from pacoxu/automated-cherry-pick-of-#1124…
7ec5bc7 
…89-upstream-release-1.25

Automated cherry pick of #112489: etcd: Updated to v3.5.5
k8s-ci-robot added a commit that referenced this pull request Oct 21, 2022
@k8s-ci-robot
Merge pull request #113100 from mk46/automated-cherry-pick-of-#112489…
1e337d1 
…-upstream-release-1.23

Automated cherry pick of #112489: etcd: Updated to v3.5.5
k8s-ci-robot added a commit that referenced this pull request Oct 22, 2022
@k8s-ci-robot
Merge pull request #113099 from mk46/automated-cherry-pick-of-#112489…
94ab67c 
…-upstream-release-1.24

Automated cherry pick of #112489: etcd: Updated to v3.5.5
@mzaian mzaian mentioned this pull request Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@bowei bowei Awaiting requested review from bowei

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@neolit123 neolit123

@jpbetz jpbetz

@ameukam ameukam

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dims @pacoxu @k8s-ci-robot @ameukam @serathius @ahrtr @warmchang @leilajal @neolit123 @jpbetz