Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove in-tree credential plugins (again) #112341

Merged
merged 1 commit into from Sep 9, 2022
Merged

Remove in-tree credential plugins (again) #112341

merged 1 commit into from Sep 9, 2022

Conversation

enj
Copy link
Member

@enj enj commented Sep 8, 2022

This change reverts three commits:

  1. Revert "Revert "Remove gcp and azure auth plugins""
    This reverts commit 651b4f5.
  2. Revert "update-gofmt"
    This reverts commit 79c09f0.
  3. Revert "Update removal warnings to 1.26"
    This reverts commit 68758fc.

Signed-off-by: Monis Khan mok@microsoft.com

What type of PR is this?

/kind cleanup
/kind deprecation
/triage accepted
/priority important-soon
/milestone v1.26
/assign @liggitt

xref #103498

The `gcp` and `azure` auth plugins have been removed from client-go and kubectl. See https://github.com/Azure/kubelogin and https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke for details about the cloud-specific replacements.

@enj
Remove in-tree credential plugins (again)
09cde58 
This change reverts three commits:

1. Revert "Revert "Remove gcp and azure auth plugins""
   This reverts commit 651b4f5.

2. Revert "update-gofmt"
   This reverts commit 79c09f0.

3. Revert "Update removal warnings to 1.26"
   This reverts commit 68758fc.

Signed-off-by: Monis Khan <mok@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from cjcullen, lavalamp and a team September 8, 2022 23:48
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2022
@liggitt
Copy link
Member

liggitt commented Sep 9, 2022

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit d569886 into kubernetes:master Sep 9, 2022
@dims
Copy link
Member

dims commented Sep 9, 2022

Hope it sticks

jon-stewart-eat

@aojea
Copy link
Member

aojea commented Sep 9, 2022

haha, the triple revert will be awesome

Revert "Revert

@mjhilton mjhilton mentioned this pull request Sep 26, 2022
Closed
@carlospalmaroldan carlospalmaroldan mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcullen cjcullen Awaiting requested review from cjcullen

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enj @liggitt @k8s-ci-robot @dims @aojea