Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce APIs to support CrossNamespaceVolumeDataSource #113186

Merged
merged 2 commits into from Nov 10, 2022
Merged

Introduce APIs to support CrossNamespaceVolumeDataSource #113186

merged 2 commits into from Nov 10, 2022

Conversation

ttakahashi21
Copy link
Contributor

@ttakahashi21 ttakahashi21 commented Oct 20, 2022 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR implements APIs from CrossNamespaceVolumeDataSource

API Changes:

  • Add a new namespace field to dataSourceRef field in PersistentVolumeClaim API

Which issue(s) this PR fixes:

Part of #113184

Special notes for your reviewer:

/sig storage

Does this PR introduce a user-facing change?

Add a new namespace alpha field to dataSourceRef field in PersistentVolumeClaim API.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3294-provision-volumes-from-cross-namespace-snapshots

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/code-generation labels Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ttakahashi21. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 20, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2022
@ttakahashi21
Copy link
Contributor Author

@msau42 Please review code

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 20, 2022
@mkimuram mkimuram mentioned this pull request Oct 24, 2022
Open
9 tasks
@msau42
Copy link
Member

msau42 commented Oct 25, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2022
@msau42
Copy link
Member

msau42 commented Oct 25, 2022

/assign

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 9, 2022
msau42
msau42 reviewed Nov 9, 2022
View reviewed changes
pkg/apis/core/types.go Outdated
// APIGroup is the group for the resource being referenced.
// If APIGroup is not specified, the specified Kind must be in the core API group.
// For any other third-party types, APIGroup is required.
// (Alpha) CrossNamespaceVolumeDataSource feature is restricted to snapshot.storage.k8s.io/VolumeSnapshots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true? It looks like we opened it up to any APIGroup now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not restricted by Validation, remove " (Alpha) CrossNamespaceVolumeDataSource feature is restricted to snapshot.storage.k8s.io/VolumeSnapshots.".

@msau42
Copy link
Member

msau42 commented Nov 9, 2022

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@thockin
Copy link
Member

thockin commented Nov 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, thockin, ttakahashi21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@msau42 msau42 mentioned this pull request Nov 9, 2022
Closed
@leonardpahlke
Copy link
Member

Exception request submitted by @ttakahashi21 has been accepted by the release team!

Your updated deadline to make any changes to your PR is 18:00 PST Friday 11th November 2022.

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 10, 2022
@ttakahashi21
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d94261e into kubernetes:master Nov 10, 2022
@ttakahashi21 ttakahashi21 changed the title Introduce APIs to support CrossNamespaceSourceProvisioning Introduce APIs to support CrossNamespaceVolumeDataSource Nov 11, 2022
@ttakahashi21 ttakahashi21 mentioned this pull request Nov 14, 2022
Merged
@ramrodo ramrodo mentioned this pull request Nov 14, 2022
Closed
@ttakahashi21 ttakahashi21 mentioned this pull request Nov 28, 2022
Merged
@ttakahashi21 ttakahashi21 mentioned this pull request Feb 2, 2023
Closed
@ttakahashi21 ttakahashi21 mentioned this pull request Feb 23, 2023
Closed
9 tasks
@carlory carlory mentioned this pull request Jul 5, 2023
Merged
@ttakahashi21 ttakahashi21 mentioned this pull request Jul 9, 2023
Merged
@csuzhangxc csuzhangxc mentioned this pull request Jan 2, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@bswartz bswartz bswartz left review comments

@thockin thockin thockin left review comments

@msau42 msau42 msau42 left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ttakahashi21 @k8s-ci-robot @k8s-triage-robot @leilajal @msau42 @mkimuram @thockin @leonardpahlke @xing-yang @bswartz