feat(kubectl rollout): support multiple resources for rollout status #108777

pjo256 · 2022-03-17T20:03:36Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for multiple resources in kubectl rollout status (including -R),e.g.

minikube-example ../kubernetes/_output/bin/kubectl rollout status -f deployments                                                                                                 (minikube/default)
deployment "example1" successfully rolled out
deployment "example2" successfully rolled out

where before this would fail with

error: rollout status is only supported on individual resources and resource

Which issue(s) this PR fixes:

Fixes #72216

Special notes for your reviewer:

This is my first k8s PR - should I add unit tests for kubectl rollout status in https://github.com/kubernetes/kubernetes/blob/master/test/cmd/generic-resources.sh#L359? Noticed we don't have any coverage there.

Does this PR introduce a user-facing change?

kubectl: support multiple resources for kubectl rollout status

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla · 2022-03-17T20:03:40Z

The committers listed above are authorized under a signed CLA.

✅ login: pjo256 / name: Philip Ottesen (cda4c3c1b505e2c1ed697e4fecae2a073381f770)

k8s-ci-robot · 2022-03-17T20:03:43Z

Welcome @pjo256!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-03-17T20:03:44Z

Hi @pjo256. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pjo256 · 2022-03-17T20:03:45Z

/sig cli

pjo256 · 2022-04-01T17:46:46Z

/assign @eddiezane

pjo256 · 2022-04-06T16:19:16Z

@eddiezane Any chance you'd be able to take a look?

eddiezane · 2022-04-21T18:38:58Z

/ok-to-test

ardaguclu · 2022-05-09T13:47:24Z

staging/src/k8s.io/kubectl/pkg/cmd/rollout/rollout_status.go

@@ -168,73 +168,67 @@ func (o *RolloutStatusOptions) Run() error {
 		LabelSelectorParam(o.LabelSelector).
 		FilenameParam(o.EnforceNamespace, o.FilenameOptions).
 		ResourceTypeOrNameArgs(true, o.BuilderArgs...).
-		SingleResourceType().
+		ContinueOnError().


Could you please elaborate what will happen if one of resources get error like in here https://github.com/kubernetes/kubernetes/pull/108777/files#diff-484e3b9bfad2141dd92637f42b9d227b2d7e91d0932bb85ec7cf098c20770691R394-R396.

Do resources, whose are not getting any error, stay in waiting stage? or we exit immediately?

We run against every visited resource as opposed to exiting immediately on the first error, e.g.

_output/bin/kubectl rollout status -f . -R --timeout=10s deployment "echoserver-1" successfully rolled out Waiting for deployment "echoserver-2" rollout to finish: 0 of 1 updated replicas are available... deployment "echoserver-3" successfully rolled out error: timed out waiting for the condition

While looking into other rollout commands, this looks consistent but I noticed these commands (pause, resume, history) have a Flatten() call prior to Do(). Do we want that call here for nested manifests?

soltysh

/triage accepted
/priority backlog
/lgtm
/approve

k8s-ci-robot · 2022-05-13T18:19:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjo256, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/kubectl/OWNERS~~ [soltysh]
~~test/cmd/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2022

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 17, 2022

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 17, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 17, 2022

k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 17, 2022

k8s-ci-robot requested review from seans3 and soltysh March 17, 2022 20:04

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 18, 2022

k8s-ci-robot assigned eddiezane Apr 1, 2022

pjo256 changed the title ~~kubectl rollout: support recursive flag for rollout status~~ kubectl rollout: support multiple resources for rollout status Apr 18, 2022

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 18, 2022

pjo256 and others added 2 commits April 21, 2022 11:17

kubectl rollout: support recursive flag for rollout status

9d8286c

tests: adding integration test for rollout status

ff8801d

pjo256 force-pushed the recursive-rollout-status branch from 4c23022 to ff8801d Compare April 21, 2022 15:23

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 21, 2022

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 21, 2022

pjo256 changed the title ~~kubectl rollout: support multiple resources for rollout status~~ feat(kubectl rollout): support multiple resources for rollout status May 6, 2022

ardaguclu reviewed May 9, 2022

View reviewed changes

soltysh approved these changes May 13, 2022

View reviewed changes

k8s-ci-robot assigned soltysh May 13, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022

k8s-ci-robot merged commit 47bb8c6 into kubernetes:master May 13, 2022

k8s-ci-robot added this to the v1.25 milestone May 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kubectl rollout): support multiple resources for rollout status #108777

feat(kubectl rollout): support multiple resources for rollout status #108777

pjo256 commented Mar 17, 2022 •

edited

linux-foundation-easycla bot commented Mar 17, 2022 •

edited

k8s-ci-robot commented Mar 17, 2022

k8s-ci-robot commented Mar 17, 2022

pjo256 commented Mar 17, 2022

pjo256 commented Apr 1, 2022

pjo256 commented Apr 6, 2022

eddiezane commented Apr 21, 2022

ardaguclu May 9, 2022

pjo256 May 9, 2022 •

edited

soltysh left a comment

k8s-ci-robot commented May 13, 2022

feat(kubectl rollout): support multiple resources for rollout status #108777

feat(kubectl rollout): support multiple resources for rollout status #108777

Conversation

pjo256 commented Mar 17, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented Mar 17, 2022 • edited

k8s-ci-robot commented Mar 17, 2022

k8s-ci-robot commented Mar 17, 2022

pjo256 commented Mar 17, 2022

pjo256 commented Apr 1, 2022

pjo256 commented Apr 6, 2022

eddiezane commented Apr 21, 2022

ardaguclu May 9, 2022

Choose a reason for hiding this comment

pjo256 May 9, 2022 • edited

Choose a reason for hiding this comment

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 13, 2022

pjo256 commented Mar 17, 2022 •

edited

linux-foundation-easycla bot commented Mar 17, 2022 •

edited

pjo256 May 9, 2022 •

edited