New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the cloud node IP annotation if it is stale #112184
Delete the cloud node IP annotation if it is stale #112184
Conversation
If you run "kubelet --cloud-provider X --node-ip Y", kubelet will set an annotation on the node, but previously, if you then ran just "kubelet --cloud-provider X" (or just "kubelet --node-ip Y"), it wouldn't delete the stale annotation. Fix that.
ddee544
to
e23f1a6
Compare
/test pull-kubernetes-integration |
/lgtm |
/assign @thockin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/triage accepted
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, mrunalp, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If you run "
kubelet --cloud-provider X --node-ip Y
", kubelet will set an annotation on the node, but previously, if you then ran just "kubelet --cloud-provider X
" (or just "kubelet --node-ip Y
"), it wouldn't delete the stale annotation. Fix that.Which issue(s) this PR fixes:
Related to #111695, but does not fix the actual reported bug there.
Does this PR introduce a user-facing change?
/sig network
/sig node
/priority important-soon
cc @mdbooth @thockin