Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting UIDs tracking expectations #111721

Merged
merged 1 commit into from Aug 5, 2022
Merged

Fix deleting UIDs tracking expectations #111721

merged 1 commit into from Aug 5, 2022

Conversation

alculquicondor
Copy link
Member

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix the deletion of expectations that we no longer need. Without this fix, the job controller memory leaks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix memory leak in the job controller related to JobTrackingWithFinalizers

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

This needs to be backported to 1.24 and 1.23 as well.

@dims
Copy link
Member

dims commented Aug 5, 2022

@alculquicondor needs milestone to be set for this to merge in master branch

@alculquicondor
Fix deleting UIDs tracking expectations
c1e0dac 
Change-Id: I5dad644cf5cb232ebed0950a14b35a781a38eeb0
@alculquicondor
Copy link
Member Author

Would you mind adding it? I don't have permissions.

janetkuo
janetkuo approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@janetkuo janetkuo added this to the v1.25 milestone Aug 5, 2022
@janetkuo
Copy link
Member

janetkuo commented Aug 5, 2022

Added to 1.25 milestone.

@k8s-ci-robot k8s-ci-robot merged commit 1374391 into kubernetes:master Aug 5, 2022
This was referenced Aug 5, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 9, 2022
@k8s-ci-robot
Merge pull request #111722 from alculquicondor/automated-cherry-pick-…
0425c85 
…of-#111721-upstream-release-1.24

Automated cherry pick of #111721: Fix deleting UIDs tracking expectations
k8s-ci-robot added a commit that referenced this pull request Aug 9, 2022
@k8s-ci-robot
Merge pull request #111723 from alculquicondor/automated-cherry-pick-…
e8633b2 
…of-#111721-upstream-release-1.23

Automated cherry pick of #111721: Fix deleting UIDs tracking expectations
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alculquicondor @k8s-ci-robot @dims @janetkuo @liggitt