New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote DS max surge to GA #111194
Promote DS max surge to GA #111194
Conversation
/sig apps |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
8811afa
to
3391077
Compare
3391077
to
ced1d2e
Compare
/retest |
1 similar comment
/retest |
looks good also we also want to promote this test to conformance once this merges right? kubernetes/test/e2e/apps/daemon_set.go Lines 502 to 503 in ff20035
|
/retest |
/remove-sig api-machinery |
For the changelog entry, please link to kubernetes/enhancements#1591 and not the PR associated with it. |
/approve API changes look good to me, the enhancement is in good order, and the docs will be a separate PR. Are there any changes to tests planned beyond what was described in the KEP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
from sig-apps pov
/hold
for additional feedback
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
@smarterclayton - As of now, nothing the units are pretty exhaustive. But if you have something in mind, please let us know, and we can add more tests @sftim - Addressed your comment. PTAL and remove hold if that is what you wanted. |
Having heard no objections |
I'm happy with the changelog here. |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: