Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Intree GCE PD tests by default #109541

Merged
merged 1 commit into from Apr 21, 2022
Merged

Disable Intree GCE PD tests by default #109541

merged 1 commit into from Apr 21, 2022

Conversation

dims
Copy link
Member

@dims dims commented Apr 19, 2022 •
edited

All the places where gcepd and windows-gcepd drivers are failing:
https://storage.googleapis.com/k8s-triage/index.html?pr=1&test=gcepd

Quote from @msau42 in #109535:

Intree GCE PD tests cannot run in k/k test infra anymore since we turned on csi migration in 1.22.

If one of the CI jobs needs it, folks can use the environment variable to switch it on.

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind cleanup
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

In-tree GCE PD test cases no longer run in Kubernetes testing harness anymore (side effect of switching on csi migration in 1.22). Please switch on environment variable ENABLE_STORAGE_GCE_PD_DRIVER to "yes" if you need to run these tests.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 19, 2022
@dims
Copy link
Member Author

dims commented Apr 19, 2022

/assign @mattcary @msau42 @xing-yang

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 19, 2022
@dims dims force-pushed the disable-intree-gce-pd-tests-by-default branch from 3bfe606 to 088a5a2 Compare April 19, 2022 12:08
@dims
Disable Intree GCE PD tests by default
a48aac4 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the disable-intree-gce-pd-tests-by-default branch from 088a5a2 to a48aac4 Compare April 19, 2022 13:22
@dims
Copy link
Member Author

dims commented Apr 19, 2022

/retest

@msau42
Copy link
Member

msau42 commented Apr 21, 2022

Please add a release note because this will impact all downstream providers running these tests.

cc @gnufied @jsafrane

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 21, 2022
@dims
Copy link
Member Author

dims commented Apr 21, 2022

@msau42 Done!

@dims
Copy link
Member Author

dims commented Apr 21, 2022

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Apr 21, 2022
@mattcary
Copy link
Contributor

/cc @khushpatil7
/lgtm

@k8s-ci-robot
Copy link
Contributor

@mattcary: GitHub didn't allow me to request PR reviews from the following users: khushpatil7.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @khushpatil7
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2022
@msau42
Copy link
Member

msau42 commented Apr 21, 2022

@dims can you update the release note with the new ENV var that should be used?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Apr 21, 2022

@msau42 Done! sorry missed that.

@krzyzacy
Copy link
Member

/cc @BenTheElder @richackard

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: GitHub didn't allow me to request PR reviews from the following users: richackard.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BenTheElder @richackard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member Author

dims commented Apr 21, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit f0791b5 into kubernetes:master Apr 21, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.24, v1.25 Apr 21, 2022
@dims dims mentioned this pull request Apr 22, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 22, 2022
@k8s-ci-robot
Merge pull request #109615 from dims/automated-cherry-pick-of-#109541…
12bc93c 
…-upstream-release-1.24

Automated cherry pick of #109541: Disable Intree GCE PD tests by default
@mattcary
Copy link
Contributor

/cc @BenTheElder

@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Open
@msau42 msau42 mentioned this pull request Jun 17, 2022
Merged
@tjungblu tjungblu mentioned this pull request Jun 22, 2022
Closed
@bertinatto bertinatto mentioned this pull request Jun 22, 2022
Merged
bertinatto added a commit to bertinatto/origin that referenced this pull request Jun 22, 2022
@bertinatto
Enable GCP PD in-tree tests
1679fdf 
Those tests have been disabled by default in k8s 1.24. See:
kubernetes/kubernetes#109541
@bertinatto bertinatto mentioned this pull request Jun 22, 2022
Merged
bertinatto added a commit to bertinatto/origin that referenced this pull request Jun 22, 2022
@bertinatto
Enable GCP PD in-tree tests
78519ac 
Those tests have been disabled by default in k8s 1.24. See:
kubernetes/kubernetes#109541
bertinatto added a commit to bertinatto/origin that referenced this pull request Jun 22, 2022
@bertinatto
Enable GCP PD in-tree tests
da3b7b4 
Those tests have been disabled by default in k8s 1.24. See:
kubernetes/kubernetes#109541
bertinatto added a commit to bertinatto/origin that referenced this pull request Jun 22, 2022
@bertinatto
Enable GCP PD in-tree tests
ef0c57f 
Those tests have been disabled by default in k8s 1.24. See:
kubernetes/kubernetes#109541
bertinatto added a commit to bertinatto/origin that referenced this pull request Jun 22, 2022
@bertinatto
Enable GCP PD in-tree tests
b2074bf 
Those tests have been disabled by default in k8s 1.24. See:
kubernetes/kubernetes#109541
This was referenced Jul 21, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@xing-yang xing-yang

@msau42 msau42

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @k8s-ci-robot @msau42 @mattcary @krzyzacy @xing-yang