New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a pending pods summary in scheudler's dummper output #111726
Conversation
@Huang-Wei: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
43211ae
to
7df9bfc
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@@ -693,7 +696,7 @@ func (p *PriorityQueue) PendingPods() []*v1.Pod { | |||
for _, pInfo := range p.unschedulablePods.podInfoMap { | |||
result = append(result, pInfo.Pod) | |||
} | |||
return result | |||
return result, fmt.Sprintf(pendingPodsSummary, p.activeQ.Len(), p.podBackoffQ.Len(), len(p.unschedulablePods.podInfoMap)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return string value directly seems a little dull, but considering it's used for debugging, I think it's ok.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of returning a map[string][]*v1.Pod
for PendingPods(), but seems a bit too much given it's for debugging purposes.
Shall we merge this in v1.26? Code freeze now. |
Yes, let's leave it to 1.26. |
What type of PR is this?
/kind cleanup
/sig scheduling
What this PR does / why we need it:
In current scheduler debugger dumpper, it outputs all the pending pods, without details knowing which of them are in activeQ/backoffQ/unschedulable map respectively
It'd be useful to expose additional summary info indicating the number of pending pods by queue types.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?