New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: graduate the UnversionedKubeletConfigMap FG to GA #110327
kubeadm: graduate the UnversionedKubeletConfigMap FG to GA #110327
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for review /cc @fabriziopandini @sbueringer |
/triage accepted |
- lock the FG to true by default - cleanup wrappers and logic related to versioned vs unversioned naming of API objects (CMs and RBAC) - update unit tests
- don't require clusteconfiguration.kubernetesVersion - use the helper functions GetConfigMap, ExpectRole, ExpectRoleBinding (these were used before UnversionedKubeletConfig went Beta)
e8f9ea0
to
403ca0c
Compare
/retest |
If user upgraded the cluster in v1.24 using We should lock the feature gate to true in v1.25, but we have to keep the logic of legacy code until we remove this feature gate.
|
maybe we can add text in the release note about it. e.g. "if you were not using the new naming format (UnversionedKubeletConfigMap=false) you must manually create / copy the new unversioned kubelet config map 'kube-system/kubelet-config'" before upgrading to 1.25"
hm, but the kubeadm 1.25 binary is expected to upgrade to 1.25.x versions and not 1.24.x. |
That is acceptable. |
/lgtm |
our CI is currently broken due to failing prow pods, we might as well wait until that is resolved before merging: also this is still an issue in CI: |
/hold cancel |
What type of PR is this?
/kind deprecation cleanup feature
What this PR does / why we need it:
cmd/kubeadm
naming of API objects (CMs and RBAC)
test/e2e_kubeadm
(these were used before UnversionedKubeletConfig went Beta)
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#1582
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: