New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pass []any as any in variadic function #111048
fix pass []any as any in variadic function #111048
Conversation
|
Welcome @alingse! |
Hi @alingse. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alingse: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test good catch |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alingse, aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
I'm write a linter to lint the func call about pass []any as any in variadic function, and found this one.
see github action result here
the bug code is here.
if someone call func like
RecordFlakeIfError(err, "args is %v", arg)
,it will actually call `buildDescription([]any{[]any{"arg is %v", arg}}),
and will be failed with
optionalDescription[0].(string)
assertionWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
these two function was never called in this repo, or it will be bugfixed already.
maybe we can just delete them for useless.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: