New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a feature enabled metric #112652
add a feature enabled metric #112652
Conversation
faaddc7
to
e3eff40
Compare
Change-Id: Id872651c4219d4749fc4227da7d944e883e4e355
e3eff40
to
80024ae
Compare
featureEnabled.Reset() | ||
} | ||
|
||
func RecordFeatureEnabled(ctx context.Context, name string, enabled bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a suggestion for where something like the kubelet would wire in the calls to RecordFeatureEnabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of just throwing this in featuregate.go
? Then we're basically just done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of just throwing this in featuregate.go? Then we're basically just done.
That's fine with me, thanks.
/assign @dgrisonnet @dashpole |
Change-Id: Iccab766ba2ee16ef54abb79e41ee61a6117fa7dd
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/retest |
staging/src/k8s.io/component-base/metrics/prometheus/feature/metrics.go
Outdated
Show resolved
Hide resolved
Change-Id: Ia0f65bec6c0dc092c3db9b5b1c22059a0c8c9776
/lgtm |
/retest |
/hold cancel |
/retest |
As with the other PR, this should be listed as a feature for 1.26. |
I mean, it'll be in the release notes. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We need a generic way to determine if a feature is enabled.