New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cel admission package and the feature gate to validatingadmissionpolicy #113735
Conversation
@liggitt if you have time? It is just the package rename and ok to be in after code freeze. :) |
Btw, this seems like a good PR to also rename the feature gate to ValidatingAdmissionPolicy like we discussed offline. If you don't want to replace all the instances of CELValidatingAdmission, you could just change the value of |
/lgtm /hold in case you want to rename the feature gate in this PR, or can unhold if you want to do it in a follow-up |
Adding the milestone since this PR was already approved before code freeze and the feature gate name change seems important /milestone v1.26 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cici37, jpbetz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
1 similar comment
/retest |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is to Rename cel admission package and the feature gate to
validatingadmissionpolicy
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: