New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-596: Move CSIInlineVolume feature to GA #111258
KEP-596: Move CSIInlineVolume feature to GA #111258
Conversation
@dobsonj: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c0ca811
to
3ccd39a
Compare
44b3d30
to
963e6b9
Compare
5b1d678
to
965446c
Compare
Last push rebases to resolve a merge conflict, adds e2e tests to be promoted to conformance, and removes one more reference to this as a beta feature.
/retest |
965446c
to
5872eb5
Compare
Last test run was clean, but had to rebase again for conflicts in strategy.go and strategy_test.go. |
5872eb5
to
4c59416
Compare
4c59416
to
0ee8fed
Compare
/lgtm Thanks for adding the new test! |
/assign @liggitt |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, liggitt, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello 👋, 1.25 Release Lead here. The exception request is approved and your updated deadline to make any changes to your PR is 9:00 AM PST Monday 8th August 2022. Thank you! /milestone v1.25 |
What type of PR is this?
/kind feature
/sig storage
/milestone v1.25
/triage accepted
/priority important-soon
What this PR does / why we need it:
This updates the feature gates to move CSIInlineVolume from beta to GA in 1.25.
Which issue(s) this PR fixes:
Enhancement: KEP-596.
Special notes for your reviewer:
/cc @gnufied @jsafrane @xing-yang @jingxu97
I'd like to start review and e2e tests, but
/hold for remaining graduation criteria before merging.
The API changes are only for removal of the feature gate and references to it in the generated docs.
/kind api-change
/label api-review
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: