Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Skip "instance not found" error for LB backend address pools #111428

Merged
merged 1 commit into from Aug 22, 2022
Merged

Azure: Skip "instance not found" error for LB backend address pools #111428

merged 1 commit into from Aug 22, 2022

Conversation

lzhecheng
Copy link
Contributor

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Skip "instance not found" error for LB backend address pools
fixes: #111331

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Azure: Skip "instance not found" error for LB backend address pools

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@lzhecheng
Skip "instance not found" error for LB backend address pools
f960ff0 
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

@lzhecheng: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 26, 2022
@lzhecheng lzhecheng changed the title Skip "instance not found" error for LB backend address pools Azure: Skip "instance not found" error for LB backend address pools Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 26, 2022
@lzhecheng
Copy link
Contributor Author

/retest

@lzhecheng
Copy link
Contributor Author

/assign @feiskyer
cc @ydp

feiskyer
feiskyer approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2022
@lzhecheng
Copy link
Contributor Author

@nckturner could you please take a look? Thanks.

@nckturner
Copy link
Contributor

/approve

Bug fix

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@feiskyer
Copy link
Member

Add to v1.25 as this is a serious bug fix.

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit a1128e3 into kubernetes:master Aug 22, 2022
@ydp
Copy link

ydp commented Aug 23, 2022

Hi maintainers, would you back port the fix to 1.24 and 1.23?

@lzhecheng lzhecheng deleted the skip-instance-not-found branch August 24, 2022 06:36
@lzhecheng lzhecheng mentioned this pull request Aug 24, 2022
Merged
@lzhecheng lzhecheng mentioned this pull request Aug 24, 2022
Merged
@nckturner
Copy link
Contributor

/approve

k8s-ci-robot added a commit that referenced this pull request Sep 30, 2022
@k8s-ci-robot
Merge pull request #111994 from lzhecheng/automated-cherry-pick-of-#1…
3c4a08f 
…11428-upstream-release-1.23

Automated cherry pick of #111428: Skip "instance not found" error for LB backend address pools
k8s-ci-robot added a commit that referenced this pull request Sep 30, 2022
@k8s-ci-robot
Merge pull request #111993 from lzhecheng/automated-cherry-pick-of-#1…
d5b5d66 
…11428-upstream-release-1.24

Automated cherry pick of #111428: Skip "instance not found" error for LB backend address pools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

skip "instance not found" error when reconciling LB backend address pools
5 participants
@lzhecheng @k8s-ci-robot @nckturner @feiskyer @ydp