Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap name for storage metric for underlying storage db #113310

Merged
merged 1 commit into from Oct 25, 2022

Conversation

logicalhan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleanup storage metric as to not directly reference etcd. This is needed for promotion to STABLE metric status.

Does this PR introduce a user-facing change?

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`.

Change-Id: Ic7cd9bf5ef29d9c51a728ef37c94d77172fbf678
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added area/apiserver approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2022
@logicalhan
Copy link
Member Author

/retest

@lavalamp
Copy link
Member

/lgtm
/approve

Shouldn't people be monitoring the storage system directly? Why does apiserver have this metric at all?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19ab5b6 into kubernetes:master Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 25, 2022
@wojtek-t
Copy link
Member

This looks reasonable to me.

@mborsz @marseel @mm4tt - to double check we don't rely on it somewhere in GKE

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 27, 2022
ialidzhikov added a commit to gardener/gardener that referenced this pull request Dec 25, 2022
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Dec 28, 2022
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Dec 30, 2022
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Dec 30, 2022
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Dec 30, 2022
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Jan 13, 2023
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to gardener/gardener that referenced this pull request Jan 13, 2023
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
ialidzhikov added a commit to ialidzhikov/gardener that referenced this pull request Jan 13, 2023
…server_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Jan 16, 2023
* Allow instantiating v1.26 Kubernetes clients

* Update `README.md` and `docs/usage/supported_k8s_versions.md` for the K8s 1.26

* Maintain Kubernetes feature gates

$ ./hack/compare-k8s-feature-gates.sh 1.25 1.26
Feature gates added in 1.26 compared to 1.25:
APISelfSubjectReview
AggregatedDiscoveryEndpoint
ConsistentHTTPGetHandlers
CrossNamespaceVolumeDataSource
DynamicResourceAllocation
EventedPLEG
LegacyServiceAccountTokenTracking
MinimizeIPTablesRestore
PDBUnhealthyPodEvictionPolicy
PodSchedulingReadiness
StatefulSetStartOrdinal
TopologyManagerPolicyAlphaOptions
TopologyManagerPolicyBetaOptions
TopologyManagerPolicyOptions
ValidatingAdmissionPolicy
WindowsHostNetwork

Feature gates removed in 1.26 compared to 1.25:
CSIMigrationOpenStack
CSRDuration
DefaultPodTopologySpread
DynamicKubeletConfig
IndexedJob
NonPreemptingPriority
PodAffinityNamespaceSelector
PodOverhead
PreferNominatedNode
ServiceLBNodePortControl
ServiceLoadBalancerClass
SuspendJob

Feature gates locked to default in 1.26 compared to 1.25:
CPUManager
CSIMigrationvSphere
DelegateFSGroupToCSIDriver
DevicePlugins
DryRun
EndpointSliceTerminatingCondition
JobTrackingWithFinalizers
KubeletCredentialProviders
MixedProtocolLBService
ServerSideApply
ServiceIPStaticSubrange
ServiceInternalTrafficPolicy
WindowsHostProcessContainers

* Maintain `kube-apiserver` admission plugins

$ ./hack/compare-k8s-admission-plugins.sh 1.25 1.26
Admission plugins added in 1.26 compared to 1.25:
ValidatingAdmissionPolicy

Admission plugins removed in 1.26 compared to 1.25:

* Maintain `ServiceAccount` names for the controllers part of `kube-controller-manager`

$ ./hack/compare-k8s-controllers.sh 1.25 1.26

kube-controller-manager controllers added in 1.26 compared to 1.25:
resource-claim-controller

kube-controller-manager controllers removed in 1.26 compared to 1.25:

* Use 1.26 for local shoot and local e2e test

* Deprecate the `podEvictionTimeout` field in favor of newly introduced kube-apiserver fields

The kube-controller-manager flag `--pod-eviction-timeout` is deprecated in favor of the kube-apiserver flags `--default-not-ready-toleration-seconds` and `--default-unreachable-toleration-seconds`. The `--pod-eviction-timeout` flag does not have effect when the taint besed eviction is enabled. The taint  based eviction is beta (enabled by default) since Kubernetes 1.13 and GA since Kubernetes 1.18. For more details, see kubernetes/kubernetes#74651.

This commit allows configuring the kube-apiserver flags `--default-not-ready-toleration-seconds` and `--default-unreachable-toleration-seconds`. The `podEvictionTimeout` field is deprecated in favor of the newly introduced fields. gardener-apiserver no longer defaults the `podEvictionTimeout` field. gardener-apiserver also returns a warning when the `podEvictionTimeout` field is set.

* Adapt to the renaming of `etcd_db_total_size_in_bytes` metric to `apiserver_storage_db_total_size_in_bytes`

The metric `etcd_db_total_size_in_bytes` is renamed to `apiserver_storage_db_total_size_in_bytes`. Ref kubernetes/kubernetes#113310.

* Fix the Pod spec in `simple-load-deployment.yaml.tpl`

Test runs of the integration test that uses this template prints the following warning about the issue in the template:
```
{"level":"info","ts":"2022-12-28T19:36:29.043+0200","logger":"KubeAPIWarningLogger","msg":"unknown field \"spec.template.spec.containers[0].nodeName\""}
```

* Update `docs/usage/shoot_credentials_rotation.md`

After the removal of support for Kubernetes < 1.20 Shoot clusters (ref #6987), the kubeconfig Secret no longer has the `token` field. Basic auth cannot be enabled for K8s 1.19+ clusters, hence the kubeconfig Secret cannot contain the `username`/`password` fields anymore.

* Default `enableStaticTokenKubeconfig` to false for Shoots with K8s version >= 1.26

This commit also adapts most of the testmachinery integration tests to use the `shoots/adminkubeconfig` subresource instead of the static kubeconfig.
The Shoot creation intergration is still using the static kubeconfig and it is downloading it to `$TM_KUBECONFIG_PATH/shoot.config`. This commit sets `enableStaticTokenKubeconfig=true` until we figure out which tests/components are using this downloaded kubeconfig.

* Add constraint for K8s version < 1.26

The constraint `ConstraintK8sLess126` is currently not used by gardener/gardener but it is introduced for usage from the extensions.

* Address review comments

* Update `new-kubernetes-version.md` guide with details about the `hyperkube` image

* Update `supported_k8s_versions.md` for K8s 1.26

* Update kube-scheduler component's unit tests for K8s 1.26

* Revert the K8s versions used for e2e tests

For the reasoning, see #7275 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants