New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick 114857 to release-1.24 #114865
Conversation
/sig api-machinery |
TestCostEstimation unit test failure looks... related and surprising. Did we need to react to that change in 1.25+ |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 1b0de8ab796e566308d15cccba2028c5de76514a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes #114661 by picking up google/cel-go#620
This bug can cause all requests matching the admission rules fail with an error rather than be properly validated.
Which issue(s) this PR fixes:
Fixes #114661
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: