Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote ProxyTerminatingEndpoints feature to Beta #113363

Merged
merged 1 commit into from Nov 3, 2022
Merged

promote ProxyTerminatingEndpoints feature to Beta #113363

merged 1 commit into from Nov 3, 2022

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Oct 26, 2022 •
edited

Signed-off-by: Andrew Sy Kim andrewsy@google.com

What type of PR is this?

/kind feature

kubernetes/enhancements#1672

What this PR does / why we need it:

Per KEP update in kubernetes/enhancements#3505, this PR promote the ProxyTerminatingEndpoints feature to Beta. This feature has been alpha since v1.22 and meets following graduation criterias for Beta:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The ProxyTerminatingEndpoints feature is now Beta and enabled by default. When enabled, kube-proxy will attempt to route traffic to terminating pods when the traffic policy is Local and there are only terminating pods remaining on a node.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@andrewsykim
promote ProxyTerminatingEndpoints feature to Beta
8c77295 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 26, 2022
@k8s-ci-robot
Copy link
Contributor

@andrewsykim: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2022
@andrewsykim
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2022
@andrewsykim
Copy link
Member Author

/retest

@parul5sahoo parul5sahoo mentioned this pull request Nov 1, 2022
Closed
@andrewsykim
Copy link
Member Author

/assign @bowei @thockin

@andrewsykim
Copy link
Member Author

/retest

@thockin thockin added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 2, 2022
@thockin
Copy link
Member

thockin commented Nov 2, 2022

/approve
/lgtm

Not sure why it is held, still?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@aojea
Copy link
Member

aojea commented Nov 2, 2022

Not sure why it is held, still?

/retest

the failing test it was fixed by #113548

@andrewsykim can we unhold? or you want to address the TODO?

Manual or automated rollback testing - TODO

@andrewsykim
Copy link
Member Author

/hold cancel

Manual or automated rollback testing - TODO

Yeah I can do this manually outside this PR

@k8s-ci-robot k8s-ci-robot merged commit fccd8b1 into kubernetes:master Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
@andrewsykim andrewsykim mentioned this pull request Nov 9, 2022
Closed
@andrewsykim andrewsykim mentioned this pull request Nov 22, 2022
Merged
@howardjohn howardjohn mentioned this pull request Dec 9, 2022
Closed
@dddddai dddddai mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewsykim @k8s-ci-robot @thockin @aojea @bowei