New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e framework: replace custom cleanup support with Ginkgo v2 mechanisms #111998
e2e framework: replace custom cleanup support with Ginkgo v2 mechanisms #111998
Conversation
@pohly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm going to take this into #112043. /close |
@pohly: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen I need these changes for #112043 but it might be better to review and merge them separately. |
@pohly: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
deae526
to
cae830e
Compare
cae830e
to
3c6880d
Compare
3c6880d
to
954146e
Compare
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
The fix for kubernetes/klog#348 is required before kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In contrast to ginkgo.AfterEach, ginkgo.DeferCleanup runs the callback in
first-in-last-out order. Using it makes the following test code work as
expected:
Previously, f.ClientSet was already set to nil by the framework's cleanup code.
Fixes: #111979
Does this PR introduce a user-facing change?