New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a metric for retroactive sc errors #113323
Conversation
@RomanBednar: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
68bfc0a
to
42422a1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a metric that is required for graduating RetroactiveDefaultStorageClass feature to beta.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is how I tested that the metric works:
1. Test that metric is registered
Metrics are registered with alpha stability
2. Test metric for retroactive SC attempt count
Disable default SC
Create PVC without SC
Check the metric is recording attempts
Make SC default again
Verify feature is enabled and working
Check there is no error metric
3. Test metric for retroactive SC attempt failure count
Disable default SC
Create PVC without SC
Flag SC as default and halt KCM process
Resume KCM process and check for errors
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: