Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric deleting_pods_total #113519

Merged
merged 3 commits into from Nov 3, 2022
Merged

Add metric deleting_pods_total #113519

merged 3 commits into from Nov 3, 2022

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Nov 1, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds metrics force_delete_pods_total and force_delete_pod_errors_total in the Pod GC Controller.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds metrics `force_delete_pods_total` and `force_delete_pod_errors_total` in the Pod GC Controller.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

@xing-yang: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 1, 2022
@xing-yang xing-yang force-pushed the node_shutdown_metrics branch 3 times, most recently from 3a24bd8 to cda5231 Compare November 2, 2022 02:06
@xing-yang
Copy link
Contributor Author

/retest

@xing-yang xing-yang changed the title WIP: Add metric deleting_pods_total Add metric deleting_pods_total Nov 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2022
@xing-yang
Copy link
Contributor Author

/assign @jsafrane @gnufied @jingxu97 @msau42

@xing-yang
Copy link
Contributor Author

/retest

@xing-yang
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2022
gnufied
gnufied reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@gnufied gnufied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cc @kubernetes/sig-instrumentation-members

pkg/controller/podgc/metrics.go Show resolved Hide resolved
pkg/controller/podgc/metrics.go Outdated Show resolved Hide resolved
logicalhan
logicalhan reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(from sig inst)

pkg/controller/podgc/metrics.go Outdated Show resolved Hide resolved
pkg/controller/podgc/metrics.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@xing-yang
Copy link
Contributor Author

@gnufied @logicalhan Comments are addressed. PTAL. Thanks.

@xing-yang
Copy link
Contributor Author

@gnufied @logicalhan Addressed your comments. PTAL. Thanks.

logicalhan
logicalhan reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(from sig instrumentation)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@xing-yang
Copy link
Contributor Author

/assign @andrewsykim

@gnufied
Copy link
Member

gnufied commented Nov 2, 2022

/lgtm

@xing-yang
Copy link
Contributor Author

/assign @dims

@dims
Copy link
Member

dims commented Nov 3, 2022

at least 3 lgtm(s). shipping it! changes look good to me as well.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 38bcc0c into kubernetes:master Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
@xing-yang xing-yang mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@logicalhan logicalhan logicalhan left review comments

@kow3ns kow3ns Awaiting requested review from kow3ns

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@gnufied gnufied

@dims dims

@logicalhan logicalhan

@jsafrane jsafrane

@andrewsykim andrewsykim

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@xing-yang @k8s-ci-robot @gnufied @dims @logicalhan @jsafrane @andrewsykim @jingxu97 @msau42