Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote endPort in Network Policy to GA #110868

Merged
merged 2 commits into from Jul 6, 2022
Merged

Promote endPort in Network Policy to GA #110868

merged 2 commits into from Jul 6, 2022

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Jun 29, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR promotes endPort field in Network Policy to GA

Which issue(s) this PR fixes:

Fixes enhancements/2079

Special notes for your reviewer:

Does this PR introduce a user-facing change?

endPort field in Network Policy is now promoted to GA

Network Policy providers that support endPort field now can use it to specify a range of ports to apply a Network Policy.

Previously, each Network Policy could only target a single port.

Please be aware that endPort field MUST BE SUPPORTED by the Network Policy provider. In case your provider does not support endPort and this field is specified in a Network Policy, the Network Policy will be created covering only the port field (single port).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2079-network-policy-port-range

/sig network
/triage accepted
/hold
/priority important-longterm
/assign @thockin @aojea @danwinship

P.S.: PR is in hold so I can write a proper RELEASE NOTE :)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation area/network-policy Issues or PRs related to Network Policy subproject area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 29, 2022
thockin
thockin reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@rikatz
Copy link
Contributor Author

rikatz commented Jul 5, 2022 •
edited

@thockin I will keep the hold and write a good RELEASE NOTE here, or maybe feature this in release blog :)

Edit: written, will unhold and check with sig-release in case we need to change this.

@rikatz
Copy link
Contributor Author

rikatz commented Jul 5, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit bd2776e into kubernetes:master Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 6, 2022
@sftim
Copy link
Contributor

sftim commented Jul 13, 2022

For the extended changelog, could we also link to https://kubernetes.io/docs/concepts/services-networking/network-policies/#targeting-a-range-of-ports?

@rhockenbury rhockenbury mentioned this pull request Jul 21, 2022
Closed
@SataQiu SataQiu mentioned this pull request Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@abhiraut abhiraut Awaiting requested review from abhiraut

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@danwinship danwinship

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/network-policy Issues or PRs related to Network Policy subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

NetworkPolicy port range
7 participants
@rikatz @k8s-ci-robot @k8s-triage-robot @sftim @thockin @danwinship @aojea